Add a versions option to BlobListOption #688

aozarov · 2016-02-29T23:10:56Z

Fixes #687.

aozarov · 2016-03-01T06:47:53Z

I added an integration test for listing with versioning enabled.

By doing so I realized 2 things:

blob delete using bucket name and blob name does not work when versioning enabled as it seems
to require a generation id (does not infer latest). Same applies to blob get without generation number (return not found).
listing a bucket with generation enabled returns nothing if versioning is not enabled in the listing operation.

gcloud-java-storage/src/test/java/com/google/gcloud/storage/it/ITStorageTest.java

-import com.google.gcloud.storage.CopyWriter;
-import com.google.gcloud.storage.HttpMethod;
-import com.google.gcloud.storage.Storage;
+import com.google.gcloud.storage.*;


Add a versions option to BlobListOption

BrandonY · 2016-03-01T18:58:37Z

Deleting a blob without specifying a generation should always (and fully consistently) delete the LIVE version of said object, if any. If there is only an archived version, the delete will fail, as it cannot find a live version.

Listing the objects in a bucket with "versions" set to false ignores the existence of archived objects. If there are no live objects, it will return no results.

aozarov · 2016-03-01T23:36:46Z

Thanks @BrandonY your description makes sense.

For the record, what confused me was that deleting a Blob (with also specifying its generation id) in a versioned bucket didn't actually delete it but rather removed its "live" status and therefore for completely deleting it (which is required if we want to delete its bucket) we need to call delete on it again.

aozarov · 2016-03-02T03:07:30Z

Correction. Actually a delete with generation id is not only removing the "live" status but will completely
remove the blob. In our case, the delete happen after a listing with selective fields which didn't include
a generation id and therefore only function as a "live" status change.

…1.2 (googleapis#688) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `24.1.1` -> `24.1.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/compatibility-slim/24.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.2/confidence-slim/24.1.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).

🤖 I have created a release *beep* *boop* --- ## [0.34.0](googleapis/java-phishingprotection@v0.33.1...v0.34.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#685](googleapis/java-phishingprotection#685)) ([6a86faa](googleapis/java-phishingprotection@6a86faa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.2.0](googleapis/java-os-login@v2.1.0...v2.2.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#694](googleapis/java-os-login#694)) ([a82410e](googleapis/java-os-login@a82410e)) ### Bug Fixes * make java.base fields accessible to fix java 17 runtime errors. ([googleapis#688](googleapis/java-os-login#688)) ([51a9a6f](googleapis/java-os-login@51a9a6f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#693](googleapis/java-os-login#693)) ([ecb4469](googleapis/java-os-login@ecb4469)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

…onfig to v1.5.1 (#688) * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…vers to v2.3.0 (#688) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-game-servers](https://togithub.com/googleapis/java-game-servers-v1beta) | `2.2.1` -> `2.3.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-game-servers/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-game-servers).

- [ ] Regenerate this pull request now. chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: https://github.com/googleapis/googleapis-gen/commit/6a4d9d9bb3afb20b0f5fa4f5d9f6740b1d0eb19a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1575) (#688) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

… to v2.3.5 (#688) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-memcache](https://togithub.com/googleapis/java-memcache) | `2.3.4` -> `2.3.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/compatibility-slim/2.3.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-memcache/2.3.6/confidence-slim/2.3.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-memcache).

Add a versions option to BlobListOption

21e68cc

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 29, 2016

aozarov added api: storage Issues related to the Cloud Storage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 29, 2016

add list versioned blobs to integration tests

438896b

aozarov force-pushed the master branch from c7b5859 to 438896b Compare March 1, 2016 06:26

aozarov removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 1, 2016

mziccard reviewed Mar 1, 2016
View reviewed changes

fix style and formatting issue

e66c9a4

mziccard added a commit that referenced this pull request Mar 1, 2016

Merge pull request #688 from aozarov/master

3930ff9

Add a versions option to BlobListOption

mziccard merged commit 3930ff9 into googleapis:master Mar 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a versions option to BlobListOption #688

Add a versions option to BlobListOption #688

aozarov commented Feb 29, 2016

aozarov commented Mar 1, 2016

This comment was marked as spam.

This comment was marked as spam.

BrandonY commented Mar 1, 2016

aozarov commented Mar 1, 2016

aozarov commented Mar 2, 2016

Add a versions option to BlobListOption #688

Add a versions option to BlobListOption #688

Conversation

aozarov commented Feb 29, 2016

aozarov commented Mar 1, 2016

This comment was marked as spam.

This comment was marked as spam.

BrandonY commented Mar 1, 2016

aozarov commented Mar 1, 2016

aozarov commented Mar 2, 2016